Skip to content

DOCSP-41993 Compatibility Table #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Sep 19, 2024

Conversation

lindseymoore
Copy link
Collaborator

@lindseymoore lindseymoore commented Sep 5, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41993
Staging - https://deploy-preview-126--docs-php-library.netlify.app/compatibility/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@lindseymoore lindseymoore requested review from a team and alcaeus and removed request for a team September 5, 2024 19:48
@lindseymoore
Copy link
Collaborator Author

Hi @alcaeus! Do you know if there is any change in language compatibility for 1.20? Would appreciate your review as well. Thanks!

@alcaeus
Copy link
Member

alcaeus commented Sep 6, 2024

The 1.20 release will support PHP 7.4, 8.0, 8.1, 8.2, 8.3, and 8.4. We are dropping support for PHP 7.4 and 8.0 in 1.21, coming later this year.

Given the size of the compat table, I would suggest dropping the rows for PHP 7.2 and older, as those PHP versions have been EOL for a long time already. You can look at the supported versions for more info - for example, PHP 7.3 has been EOL'd for almost 3 years at this point.

I would also suggest dropping MongoDB versions older than 3.4 - we don't actively support those server versions anymore and I believe indicating that 3.4 is not supported by any recent driver version should be sufficient. I'll defer to your judgment on this though.

Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compat tables LGTM

snooty.toml Outdated
@@ -20,6 +20,8 @@ toc_landing_pages = [
"/get-started",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do? @rustagir

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it makes it so that you can use anchors in a ref construction from other repos!

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for docs-php-library ready!

Name Link
🔨 Latest commit ae53fbb
🔍 Latest deploy log https://app.netlify.com/sites/docs-php-library/deploys/66ec7ef502f07600097b5412
😎 Deploy Preview https://deploy-preview-126--docs-php-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a few small suggestions, I can take another look if needed!

snooty.toml Outdated
@@ -20,6 +20,8 @@ toc_landing_pages = [
"/get-started",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it makes it so that you can use anchors in a ref construction from other repos!

Comment on lines 151 to 158
* - ext 1.3 + lib 1.2
-
-
-
-
-
-
- ✓
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: Can you check in with the PHP team or Andreas about whether we can remove some of these old versions from this table? Right now, the table is very long as it includes all of these old php driver versions

Copy link
Collaborator Author

@lindseymoore lindseymoore Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alcaeus, are we able to remove any of the older versions of the php driver from either the MongoDB or Language compatibility table?
Also, will be working on a What's New page referencing the PHP release notes. What is the oldest version you would include as relevant on a What's New page? Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These old versions definitely aren't relevant anymore. I think we can drop anything older than ext 1.14 and lib 1.13, as those were released two years ago.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Slack conversation, will remove older than ext + lib 1.15

@lindseymoore lindseymoore merged commit 9ad7615 into mongodb:php-standardization Sep 19, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants