Skip to content

DOCSP-42819: add coding standards workflow #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 23, 2024

Conversation

rustagir
Copy link
Collaborator

@rustagir rustagir commented Aug 21, 2024

Pull Request Info

JIRA - https://jira.mongodb.org/browse/DOCSP-42819

Adapted the actions from the source driver repo but changed the rules for when the action should be run and on which filetypes

Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for docs-php-library failed. Why did it fail? →

Name Link
🔨 Latest commit 00c1a2a
🔍 Latest deploy log https://app.netlify.com/sites/docs-php-library/deploys/66c8baf0885d9c0008cbe5a2

@GromNaN GromNaN self-requested a review August 21, 2024 21:52
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a composer.json to install the tools:

    "require": {
        "mongodb/mongodb": "^1.20"
    },
    "require-dev": {
        "doctrine/coding-standard": "^12.0",
        "squizlabs/php_codesniffer": "^3.7",
        "vimeo/psalm": "^5.13"
    }
}

@rustagir rustagir requested a review from GromNaN August 22, 2024 14:28
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the phpcs and psalm rules to make the tests pass.

@rustagir rustagir merged commit 1c719fe into master Aug 23, 2024
5 of 10 checks passed
@rustagir rustagir deleted the DOCSP-42819-add-coding-standard-wkflw branch February 4, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants