DOCSP-41979: Distinct values #109

norareidy · 2024-08-20T18:11:17Z

Pull Request Info

JIRA - https://jira.mongodb.org/browse/DOCSP-41979
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-41979-distinct/read/distinct/

Self-Review Checklist

Is this free of any warnings or errors in the RST?
Did you run a spell-check?
Did you run a grammar-check?
Are all the links working?
Are the facets and meta keywords accurate?

norareidy · 2024-08-20T18:33:51Z

source/read/distinct.txt

+You can provide a **query filter** to the ``distinct()`` method to find the distinct
+field values across a subset of documents in a collection. A query filter is an expression
+that specifies search criteria used to match documents in an operation. For more information
+about creating a query filter, see the :ref:`php-specify-query` guide.


Note: link broken until #103 is merged

jordan-smith721

LGTM + a couple suggestions

jordan-smith721 · 2024-08-20T18:49:18Z

source/read/distinct.txt

+   .. output:: 
+      :visible: false


S: Show output here since it's relevant to the next paragraph

Suggested change

.. output::

:visible: false

.. output::

jordan-smith721 · 2024-08-20T18:53:21Z

source/read/distinct.txt

+To learn more about the ``MongoDB\Collection::distinct()`` method, see the following
+API documentation:
+
+- `distinct() <{+api+}/method/MongoDBCollection-distinct/>`__


S: Make this a sentence since there is only one link here

Suggested change

To learn more about the ``MongoDB\Collection::distinct()`` method, see the following

API documentation:

- `distinct() <{+api+}/method/MongoDBCollection-distinct/>`__

To learn more about the ``MongoDB\Collection::distinct()`` method, see the

`distinct() API documentation <{+api+}/method/MongoDBCollection-distinct/>`__.

alcaeus · 2024-08-28T12:31:34Z

source/includes/read/distinct.php

+// Retrieves distinct "name" field values for documents matching the "borough" and "cuisine" fields query
+// and attaches a comment to the operation
+// start-distinct-with-comment
+$query = ['$and' => [['borough' => 'Bronx'], ['cuisine' => 'Pizza']]];


Is the $and operator strictly necessary here? Wouldnt the following achieve the same while being easier to read?

Suggested change

$query = ['$and' => [['borough' => 'Bronx'], ['cuisine' => 'Pizza']]];

$query = ['borough' => 'Bronx', 'cuisine' => 'Pizza'];

…P-41979-distinct

* Add PR template * Scaffolding * DOCSP-41953: Create a deployment (#93) * DOCSP-41953: Create a deployment * toc * add troubleshoot file * DOCSP-41954: Create a connection string (#99) * DOCSP-41954: Create a connection string * edits * spacing * DOCSP-42388: Next steps (#101) * DOCSP-41975: Retrieve data (#102) * DOCSP-41975: Retrieve data * fixes * quotes * code fix * JS feedback * JT feedback * code format * fix * JT feedback 2 * edit * DOCSP-41952: Download and Install (#92) * DOCSP-41952: Download and Install * edits * toc, fixes * AS feedback * AS feedback 2 * typo * JT feedback * DOCSP-41976: Projection guide (#104) * DOCSP-41976: Projection guide * edits * fixes * code edits, output * JS feedback * JT feedback * DOCSP-41955: Connect to MongoDB (#100) * DOCSP-41955: Connect to MongoDB * edits * edit * RR feedback * typo * code edit * DOCSP-41974: Specify a query (#103) * DOCSP-41974: Specify a query * edits * output * fix * snooty.toml * RR feedback * code edits * DOCSP-41977: Specify documents to return (#105) * DOCSP-41977: Specify documents to return * edits * code output * toc * MM feedback, code edits * edit * JT feedback * edit * test * MM feedback 2 * DOCSP-41957 - Mongo Client (#106) Co-authored-by: Rea Rustagi <85902999+rustagir@users.noreply.github.com> * DOCSP-41960 - TLS (#114) * DOCSP-41978: Count documents (#108) * DOCSP-41978: Count documents * edits * code ex format * link * RR feedback * DOCSP-41979: Distinct values (#109) Adds a Distinct Values guide. * DOCSP-41981: Change streams (#113) Adds a Change Streams guide. * DOCSP-41993 Compatibility Table * test webhook * toc and sharedincludes * lang table * edits * headings * retry on shared include * shared includes * callout * help links * DOCSP-41958 - Connection Targets (#107) Co-authored-by: Nora Reidy <nora.reidy@mongodb.com> Co-authored-by: Andreas Braun <git@alcaeus.org> * tech review * DOCSP-41968: Update documents (#118) * DOCSP-41968: Update documents * snooty fix * edits * DOCSP-41967: Insert documents (#116) * DOCSP-41967: Insert documents * build * snooty * edit * JS feedback * JT feedback * JT feedback 2 * DOCSP-41980: Cursor guide (#110) * DOCSP-41980: Cursor guide * edits * code edits * output * vale fix * MM feedback * edit * fix code ex * edit * JT feedback * DOCSP-41988: Aggregation (#115) * DOCSP-41988: Aggregation * toc * edits * code edit * JS feedback * dev center * JM feedback * explain api link * JM feedback 2 * DOCSP-41983: indexes landing pg * wip * wip * MM PR fixes 1 * JM tech review 1 * JM tech review 1 * wip * wip * DOCSP-41969: Replace documents (#125) * DOCSP-41969: Replace documents * edits * wording * SA * JT feedback * JM tech review 2 * Add files via upload * DOCSP-41970: Delete documents (#128) Adds a guide that shows how to delete documents. * DOCSP-41984: single field index * wip * JS PR fixes 1 * wip * DOCSP-41986: multikey indexes * links * bullet pts * JS suggestion * fix whitespace per JM comment * uncomment * DOCSP-41985: compound idx * small fix * DOCSP-41966: Write operations landing (#135) * DOCSP-41966: Write operations landing * edits * RR feedback * JT feedback * JT feedback 2 * gridfs examples * DOCSP-42026: In use encryption (#142) * DOCSP-42026: In use encryption * edit * DOCSP-41972: GridFS guide (#133) * DOCSP-41972: GridFS guide * fixes * code edits * fix * RR feedback * phpmethod * fix * JM most feedback * alternate upload/download methods * file revisions * code fix * tojson * edits * JM feedback 2 * edits * JM last feedback * DOCSP-41971: Bulk write (#130) * DOCSP-41971: Bulk write * edits * JS feedback * api links * DOCSP-41987: atlas search idx * resolve todos * toc * DOCSP-41963: Databases and collections (#136) * DOCSP-41963: Databases and collections * edits * phpmethod * code fix * MW feedback * fix * MW feedback 2 * JM feedback * JM feedback 2 * JS fix * internal review * DOCSP-41982: cluster monitoring * small fixes * MW PR fixes 1 * test netlify * spacing * try using out of repo ref and add back legend * ou of repo ref * legend glitch * JM tech review 1 * single quotes * links * vale * remove older driver version past 1.15 * DOCSP-41991 What's New * add rest of versions * fix links * fix links * JM tech review 2 * DOCSP-41964: Time series collections (#138) * DOCSP-41964: Time series collections * toc * edits * keywords * SA feedback * JT feedback * JM final fixes * review comments * typo * DOCSP-41973 Read Landing Page * review comments * vale errors * small thing * full page with ex * add page * meta * DOCSP-41965: Read and write settings (#146) * DOCSP-41965: Read and write settings * more info * edits * edits * headers * fix link * fix * RR feedback * api docs * fix * fix * DOCSP-41950: Landing page (#150) * DOCSP-41950: Landing page * fix build errors * fixes, data formats * toc * fix * data formats folder * RR feedback * fix * remove file * edit sample app intro * change links in count sections * update sample app intro * DOCSP-41990: Authentication mechanisms (#139) * DOCSP-41990: Authentication mechanisms * client tabs * edits * edits * add info * reduce repetition * add section * fix link * MW feedback * fix * JM most feedback * move to code file * more JM edits * JM feedback 2 * DOCSP-41989: Security landing page (#149) * DOCSP-41989: Security landing page * more info * edits * snooty.toml * edits * RR feedback * JM feedback * DOCSP-41962 - Stable API (#117) Co-authored-by: Jeremy Mikola <jmikola@gmail.com> * DOCSP-41992 Upgrade versions * toc * edits * how to upgrade sections * style * edit * edit * review comments * ref * Revise descriptions for server opening/closed events * DOCSP-43204: Connection landing page (#147) * DOCSP-43204: Connection landing page * toc edit * edits * remove compression * fix * sample app * snooty * JM feedback * replica set * JM feedback 2 * JM last feedback * DOCSP-43819: php 1.20 release * fix * DOCSP-41956: run a command * wip * formatting fix * JS PR fixes 1 * link fix * style fixes * JT tech review 1 * wip * JM tech review * tree * api links * links * JM tech review 2 * small fixes * add ext upgrade command * DOCSP-41995: transaction * wip * update code * NR PR fixes 1 * wip * add emphasis * add with_txn() method to api links * cxn string env * edit * JM tech review 1 * remove dupe sc * tech review * wrap fix * edit copy * DOCSP-41959 - Connection Options (#112) Co-authored-by: Nora Reidy <nora.reidy@mongodb.com> Co-authored-by: Jeremy Mikola <jmikola@gmail.com> * DOCSP-43396: Cleanup (#151) * DOCSP-43396: Cleanup * quickstart fix * code fixes * edit * snooty * edit * code output * build log errors * another build fix * add info * upgrade guide to landing * fix * driver mentions * RR feedback * build fix * build fix * php directives --------- Co-authored-by: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Co-authored-by: Rea Rustagi <85902999+rustagir@users.noreply.github.com> Co-authored-by: Lindsey Moore <lindsey.moore@mongodb.com> Co-authored-by: Andreas Braun <git@alcaeus.org> Co-authored-by: rustagir <rea.rustagi@mongodb.com> Co-authored-by: Brandon Ly <brandonly@lostcoding.com> Co-authored-by: lindseymoore <71525840+lindseymoore@users.noreply.github.com> Co-authored-by: Jeremy Mikola <jmikola@gmail.com>

norareidy added 3 commits August 20, 2024 14:00

DOCSP-41979: Distinct values

1a32205

edits

4dd9f25

more edits

509c146

norareidy commented Aug 20, 2024

View reviewed changes

jordan-smith721 approved these changes Aug 20, 2024

View reviewed changes

JS feedback

6241c8a

norareidy requested review from a team and alcaeus and removed request for a team August 27, 2024 14:19

alcaeus reviewed Aug 28, 2024

View reviewed changes

norareidy added 2 commits August 28, 2024 11:03

AB feedback

0ec7b6a

Merge remote-tracking branch 'upstream/php-standardization' into DOCS…

967de4f

…P-41979-distinct

norareidy requested a review from alcaeus August 28, 2024 15:04

alcaeus approved these changes Sep 2, 2024

View reviewed changes

norareidy added 2 commits September 3, 2024 13:29

Merge remote-tracking branch 'upstream/php-standardization' into DOCS…

2c194ef

…P-41979-distinct

fix

e629407

norareidy merged commit 7e0f9be into mongodb:php-standardization Sep 3, 2024
1 of 2 checks passed

norareidy deleted the DOCSP-41979-distinct branch September 3, 2024 17:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

DOCSP-41979: Distinct values #109

DOCSP-41979: Distinct values #109

Uh oh!

norareidy commented Aug 20, 2024 •

edited

Loading

Uh oh!

norareidy Aug 20, 2024

Uh oh!

jordan-smith721 left a comment

Uh oh!

jordan-smith721 Aug 20, 2024

Uh oh!

jordan-smith721 Aug 20, 2024

Uh oh!

alcaeus Aug 28, 2024

Uh oh!

norareidy Aug 28, 2024

Uh oh!

Uh oh!

Uh oh!

	$query = ['$and' => [['borough' => 'Bronx'], ['cuisine' => 'Pizza']]];
	$query = ['borough' => 'Bronx', 'cuisine' => 'Pizza'];

DOCSP-41979: Distinct values #109

DOCSP-41979: Distinct values #109

Uh oh!

Conversation

norareidy commented Aug 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Info

Self-Review Checklist

Uh oh!

norareidy Aug 20, 2024

Choose a reason for hiding this comment

Uh oh!

jordan-smith721 left a comment

Choose a reason for hiding this comment

Uh oh!

jordan-smith721 Aug 20, 2024

Choose a reason for hiding this comment

Uh oh!

jordan-smith721 Aug 20, 2024

Choose a reason for hiding this comment

Uh oh!

alcaeus Aug 28, 2024

Choose a reason for hiding this comment

Uh oh!

norareidy Aug 28, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

norareidy commented Aug 20, 2024 •

edited

Loading