DOCSP-20056: UTF-8 validation options #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-carr
reviewed
Jan 26, 2022
There was a problem hiding this comment.
The page looks good but I'm not 100% sure I understand two specific things:
- What happens when you read invalid UTF-8 data from MongoDB with this validation feature enabled. Does it substitute or throw an error?
- What exactly "cannot guarantee consistent presentation of invalid UTF-8 data" means. I think it means that invalid UTF-8 data may still be substituted depending on the CRUD operations you run.
I left those questions in the review and made some small suggestions.
zach-carr
approved these changes
Jan 27, 2022
dariakp
approved these changes
Jan 28, 2022
ccho-mongodb
pushed a commit
that referenced
this pull request
Jan 31, 2022
* DOCSP-20056: UTF-8 validation options (cherry picked from commit 21babb0)
ccho-mongodb
pushed a commit
that referenced
this pull request
Sep 23, 2022
* DOCSP-20056: UTF-8 validation options (cherry picked from commit f337757)
ccho-mongodb
pushed a commit
to ccho-mongodb/docs-node
that referenced
this pull request
Sep 23, 2022
* DOCSP-20056: UTF-8 validation options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
Issue JIRA link:
https://jira.mongodb.org/browse/DOCSP-20056
Snooty build log:
https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=61f2c8ddbcf82347e58d0b02
Docs staging link (requires sign-in on MongoDB Corp SSO):
What's New link
ToC
UTF-8 Validation Page
Self-Review Checklist
If your page documents a concept, does it meet the following criteria?