Skip to content

DOCSP-20256: 4.3 updates #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2022

Conversation

ccho-mongodb
Copy link
Contributor

@ccho-mongodb ccho-mongodb commented Jan 7, 2022

Pull Request Info

Issue JIRA link:

https://jira.mongodb.org/browse/DOCSP-20256

Snooty build log:

https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=61d8b56c41accb3633cd0754

Docs staging link (requires sign-in on MongoDB Corp SSO):

https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/DOCSP-20256-4.3-release/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Does it render on staging correctly?
  • Are all the links working?
  • Are the staging and workerpool job links in the PR description updated?

If your page documents a concept, does it meet the following criteria?

Copy link
Contributor

@biniona-mongodb biniona-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments and questions

Comment on lines 2 to 4
:header-rows: 1
:stub-columns: 1
:class: compatibility-large
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Any reason these were indented further? I think I'm used to these aligning with the list-table directive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, guess it's a bug in my compatibility table update script.

-
-
-
-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment: I think the last row header is cut off on the table. All I can see is a "check mark" without a label.
Screen Shot 2022-01-07 at 5 01 55 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I think a bug in my script added an extra check mark on line 171


- SOCKS5 support
- Option to disable UTF-8 validation
- Type inference for nested documents
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Is this related to DOCSP-20071? If yes, maybe the wording of this could be changed to stress dot notation. Maybe "supporting type inference in queries written using dot notation"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is directly from the release notes. I would expect this to be updated once those tickets are completed. In this case, the tickets were not completed before release, so there's no content to link to in order to clarify.

snooty.toml Outdated
@@ -5,7 +5,7 @@ toc_landing_pages = ["/fundamentals/authentication", "/fundamentals", "/fundamen
sharedinclude_root = "https://raw.githubusercontent.com/10gen/docs-shared/main/"

[constants]
version = 4.2
version = 4.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment (possible Issue): I believe Nathan is hoping that constant are written as strings going forward.

Suggested change
version = 4.3
version = "4.3"

@ccho-mongodb ccho-mongodb merged commit ed772d2 into mongodb:master Jan 10, 2022
@ccho-mongodb ccho-mongodb deleted the DOCSP-20256-4.3-release branch January 10, 2022 16:24
ccho-mongodb pushed a commit to ccho-mongodb/docs-node that referenced this pull request Sep 23, 2022
* DOCSP-20256: 4.3 updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants