-
Notifications
You must be signed in to change notification settings - Fork 52
DOCSP-20256: 4.3 updates #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-20256: 4.3 updates #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with comments and questions
:header-rows: 1 | ||
:stub-columns: 1 | ||
:class: compatibility-large |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Any reason these were indented further? I think I'm used to these aligning with the list-table directive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, guess it's a bug in my compatibility table update script.
- | ||
- | ||
- | ||
- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I think a bug in my script added an extra check mark on line 171
|
||
- SOCKS5 support | ||
- Option to disable UTF-8 validation | ||
- Type inference for nested documents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Is this related to DOCSP-20071? If yes, maybe the wording of this could be changed to stress dot notation. Maybe "supporting type inference in queries written using dot notation"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is directly from the release notes. I would expect this to be updated once those tickets are completed. In this case, the tickets were not completed before release, so there's no content to link to in order to clarify.
snooty.toml
Outdated
@@ -5,7 +5,7 @@ toc_landing_pages = ["/fundamentals/authentication", "/fundamentals", "/fundamen | |||
sharedinclude_root = "https://raw.githubusercontent.com/10gen/docs-shared/main/" | |||
|
|||
[constants] | |||
version = 4.2 | |||
version = 4.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment (possible Issue): I believe Nathan is hoping that constant are written as strings going forward.
version = 4.3 | |
version = "4.3" |
* DOCSP-20256: 4.3 updates
Pull Request Info
Issue JIRA link:
https://jira.mongodb.org/browse/DOCSP-20256
Snooty build log:
https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=61d8b56c41accb3633cd0754
Docs staging link (requires sign-in on MongoDB Corp SSO):
https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/DOCSP-20256-4.3-release/
Self-Review Checklist
If your page documents a concept, does it meet the following criteria?