Skip to content

DOCSP-19819: transactions #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jan 24, 2022

Conversation

ccho-mongodb
Copy link
Contributor

@ccho-mongodb ccho-mongodb commented Dec 22, 2021

Pull Request Info

Issue JIRA link:

https://jira.mongodb.org/browse/DOCSP-19819

Snooty build log:

https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=61eb3ccabcf82347e5671ab0

Docs staging link (requires sign-in on MongoDB Corp SSO):

https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/DOCSP-19396-transactions/fundamentals/transactions/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Does it render on staging correctly?
  • Are all the links working?
  • Are the staging and workerpool job links in the PR description updated?

If your page documents a concept, does it meet the following criteria?

@ccho-mongodb ccho-mongodb changed the title DOCSP-19396: transactions WIP DOCSP-19396: transaction Jan 10, 2022
@ccho-mongodb ccho-mongodb marked this pull request as ready for review January 10, 2022 22:25
@ccho-mongodb ccho-mongodb changed the title DOCSP-19396: transaction DOCSP-19819: transaction Jan 10, 2022
Copy link
Contributor

@zach-carr zach-carr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, some minor issues and a bunch of comments you can take or leave.

@ccho-mongodb
Copy link
Contributor Author

Hi @dariakp and @nbbeeken, this page on Node.js Driver Transactions is ready for your review!

@ccho-mongodb ccho-mongodb changed the title DOCSP-19819: transaction DOCSP-19819: transactions Jan 13, 2022
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few things I noticed:

@ccho-mongodb ccho-mongodb requested a review from dariakp January 20, 2022 16:32
@ccho-mongodb
Copy link
Contributor Author

Hi @dariakp and @nbbeeken, thanks for your feedback. I've incorporated it in the latest commits, and it's ready for re-review whenever you get the chance.

const client = new MongoClient(uri, { useUnifiedTopology: true });

async function run() {
/* Test code: uncomment block and commentto run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is. This meant to be commented out? If so, just need to fix the typo -> "commentto"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Side comment: Admittedly, this code isn't structured in a way that is easy to either demonstrate the example code nor run the example. Since we never surface it to the user, I think the structure is ok for now.

@ccho-mongodb ccho-mongodb requested a review from dariakp January 21, 2022 23:31
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ccho-mongodb ccho-mongodb merged commit 28521fb into mongodb:master Jan 24, 2022
@ccho-mongodb ccho-mongodb deleted the DOCSP-19396-transactions branch January 24, 2022 15:52
ccho-mongodb pushed a commit that referenced this pull request Jan 24, 2022
* DOCSP-19396: transactions

(cherry picked from commit 28521fb)
ccho-mongodb pushed a commit that referenced this pull request Jan 24, 2022
* DOCSP-19396: transactions

(cherry picked from commit 28521fb)
ccho-mongodb pushed a commit that referenced this pull request Jan 24, 2022
* DOCSP-19396: transactions

(cherry picked from commit 28521fb)
ccho-mongodb pushed a commit that referenced this pull request Jan 24, 2022
* DOCSP-19396: transactions

(cherry picked from commit 28521fb)
ccho-mongodb pushed a commit that referenced this pull request Jan 24, 2022
* DOCSP-19396: transactions

(cherry picked from commit 28521fb)
ccho-mongodb pushed a commit that referenced this pull request Jan 24, 2022
* DOCSP-19396: transactions

(cherry picked from commit 28521fb)
ccho-mongodb pushed a commit that referenced this pull request Sep 23, 2022
* DOCSP-19396: transactions

(cherry picked from commit a34e4a3)
ccho-mongodb pushed a commit that referenced this pull request Sep 23, 2022
* DOCSP-19396: transactions

(cherry picked from commit a34e4a3)
ccho-mongodb pushed a commit that referenced this pull request Sep 23, 2022
* DOCSP-19396: transactions

(cherry picked from commit a34e4a3)
ccho-mongodb pushed a commit that referenced this pull request Sep 23, 2022
* DOCSP-19396: transactions

(cherry picked from commit a34e4a3)
ccho-mongodb pushed a commit that referenced this pull request Sep 23, 2022
* DOCSP-19396: transactions

(cherry picked from commit a34e4a3)
ccho-mongodb pushed a commit that referenced this pull request Sep 23, 2022
* DOCSP-19396: transactions

(cherry picked from commit a34e4a3)
ccho-mongodb pushed a commit to ccho-mongodb/docs-node that referenced this pull request Sep 23, 2022
* DOCSP-19396: transactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants