-
Notifications
You must be signed in to change notification settings - Fork 52
DOCSP-19819: transactions #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-19819: transactions #271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, some minor issues and a bunch of comments you can take or leave.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are a few things I noticed:
const client = new MongoClient(uri, { useUnifiedTopology: true }); | ||
|
||
async function run() { | ||
/* Test code: uncomment block and commentto run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is. This meant to be commented out? If so, just need to fix the typo -> "commentto"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Side comment: Admittedly, this code isn't structured in a way that is easy to either demonstrate the example code nor run the example. Since we never surface it to the user, I think the structure is ok for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
* DOCSP-19396: transactions (cherry picked from commit 28521fb)
* DOCSP-19396: transactions (cherry picked from commit 28521fb)
* DOCSP-19396: transactions (cherry picked from commit 28521fb)
* DOCSP-19396: transactions (cherry picked from commit 28521fb)
* DOCSP-19396: transactions (cherry picked from commit 28521fb)
* DOCSP-19396: transactions (cherry picked from commit 28521fb)
* DOCSP-19396: transactions (cherry picked from commit a34e4a3)
* DOCSP-19396: transactions (cherry picked from commit a34e4a3)
* DOCSP-19396: transactions (cherry picked from commit a34e4a3)
* DOCSP-19396: transactions (cherry picked from commit a34e4a3)
* DOCSP-19396: transactions (cherry picked from commit a34e4a3)
* DOCSP-19396: transactions (cherry picked from commit a34e4a3)
* DOCSP-19396: transactions
Pull Request Info
Issue JIRA link:
https://jira.mongodb.org/browse/DOCSP-19819
Snooty build log:
https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=61eb3ccabcf82347e5671ab0
Docs staging link (requires sign-in on MongoDB Corp SSO):
https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/DOCSP-19396-transactions/fundamentals/transactions/
Self-Review Checklist
If your page documents a concept, does it meet the following criteria?