-
Notifications
You must be signed in to change notification settings - Fork 34
DOCSP-48942: add ARN env var assignment #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-48942: add ARN env var assignment #484
Conversation
✅ Deploy Preview for docs-golang ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small things then LGTM
source/fundamentals/auth.txt
Outdated
file that contains your OIDC token. | ||
|
||
- ``AWS_ROLE_ARN``: Set to the IAM role used to connect to your | ||
cluster, for example ``arn:aws:iam::111122223333:role/my-role``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I: comma splice
cluster, for example ``arn:aws:iam::111122223333:role/my-role``. | |
cluster. For example: ``arn:aws:iam::111122223333:role/my-role``. |
source/fundamentals/auth.txt
Outdated
|
||
.. code-block:: bash | ||
|
||
export AWS_WEB_IDENTITY_TOKEN_FILE=<absolute path to file containing your OIDC token> | ||
export AWS_WEB_IDENTITY_TOKEN_FILE=<path to file that contains OIDC token> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: my sense is that 'absolute' is important here, to distinguish this from the relative path, but maybe i'm overthinking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A relative path should work fine here, although an absolute path is sometimes recommended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
* DOCSP-48942: add ARN env var assignment * small fixes * small fixes (cherry picked from commit 97e7470)
* DOCSP-48942: add ARN env var assignment * small fixes * small fixes (cherry picked from commit 97e7470)
* DOCSP-48942: add ARN env var assignment * small fixes * small fixes (cherry picked from commit 97e7470)
* DOCSP-48942: add ARN env var assignment * small fixes * small fixes (cherry picked from commit 97e7470)
* DOCSP-48942: add ARN env var assignment * small fixes * small fixes (cherry picked from commit 97e7470)
* DOCSP-48942: add ARN env var assignment * small fixes * small fixes (cherry picked from commit 97e7470)
* DOCSP-48942: add ARN env var assignment * small fixes * small fixes (cherry picked from commit 97e7470)
* DOCSP-48942: add ARN env var assignment * small fixes * small fixes (cherry picked from commit 97e7470)
* DOCSP-48942: add ARN env var assignment * small fixes * small fixes (cherry picked from commit 97e7470)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-48942
Staging - https://deploy-preview-484--docs-golang.netlify.app/fundamentals/auth/#mongodb-aws
Self-Review Checklist