Skip to content

DOCSP-48942: add ARN env var assignment #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2025

Conversation

rustagir
Copy link
Collaborator

@rustagir rustagir commented Apr 3, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-48942
Staging - https://deploy-preview-484--docs-golang.netlify.app/fundamentals/auth/#mongodb-aws

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Apr 3, 2025

Deploy Preview for docs-golang ready!

Name Link
🔨 Latest commit 897da47
🔍 Latest deploy log https://app.netlify.com/sites/docs-golang/deploys/67efe027448bdf0008e1af64
😎 Deploy Preview https://deploy-preview-484--docs-golang.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rustagir rustagir requested a review from matthewdale April 3, 2025 20:37
Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small things then LGTM

file that contains your OIDC token.

- ``AWS_ROLE_ARN``: Set to the IAM role used to connect to your
cluster, for example ``arn:aws:iam::111122223333:role/my-role``.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I: comma splice

Suggested change
cluster, for example ``arn:aws:iam::111122223333:role/my-role``.
cluster. For example: ``arn:aws:iam::111122223333:role/my-role``.


.. code-block:: bash

export AWS_WEB_IDENTITY_TOKEN_FILE=<absolute path to file containing your OIDC token>
export AWS_WEB_IDENTITY_TOKEN_FILE=<path to file that contains OIDC token>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: my sense is that 'absolute' is important here, to distinguish this from the relative path, but maybe i'm overthinking

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A relative path should work fine here, although an absolute path is sometimes recommended.

Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@rustagir rustagir merged commit 97e7470 into mongodb:master Apr 4, 2025
5 checks passed
rustagir added a commit that referenced this pull request Apr 4, 2025
* DOCSP-48942: add ARN env var assignment

* small fixes

* small fixes

(cherry picked from commit 97e7470)
rustagir added a commit that referenced this pull request Apr 4, 2025
* DOCSP-48942: add ARN env var assignment

* small fixes

* small fixes

(cherry picked from commit 97e7470)
rustagir added a commit that referenced this pull request Apr 4, 2025
* DOCSP-48942: add ARN env var assignment

* small fixes

* small fixes

(cherry picked from commit 97e7470)
rustagir added a commit that referenced this pull request Apr 4, 2025
* DOCSP-48942: add ARN env var assignment

* small fixes

* small fixes

(cherry picked from commit 97e7470)
rustagir added a commit that referenced this pull request Apr 4, 2025
* DOCSP-48942: add ARN env var assignment

* small fixes

* small fixes

(cherry picked from commit 97e7470)
rustagir added a commit that referenced this pull request Apr 4, 2025
* DOCSP-48942: add ARN env var assignment

* small fixes

* small fixes

(cherry picked from commit 97e7470)
rustagir added a commit that referenced this pull request Apr 4, 2025
* DOCSP-48942: add ARN env var assignment

* small fixes

* small fixes

(cherry picked from commit 97e7470)
rustagir added a commit that referenced this pull request Apr 4, 2025
* DOCSP-48942: add ARN env var assignment

* small fixes

* small fixes

(cherry picked from commit 97e7470)
mongoKart pushed a commit that referenced this pull request Jun 10, 2025
* DOCSP-48942: add ARN env var assignment

* small fixes

* small fixes

(cherry picked from commit 97e7470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants