Skip to content

ci: publish to npm #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 8, 2025
Merged

ci: publish to npm #9

merged 7 commits into from
Apr 8, 2025

Conversation

fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Apr 8, 2025

  • runs npm publish when a new tag is created
  • adds dist folder to gitignore
  • calls npm run build before packing the npm package

@fmenezes fmenezes marked this pull request as ready for review April 8, 2025 13:12
gagik
gagik previously approved these changes Apr 8, 2025
Copy link
Collaborator

@gagik gagik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

package.json Outdated
"reformat": "npx prettier -- --write ."
"check:lint": "eslint .",
"check:format": "prettier -c .",
"reformat": "npx prettier --write ."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"reformat": "npx prettier --write ."
"reformat": "prettier --write ."

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more of a drive by but realizing now that npx is redundant here for build:compile as well

@fmenezes fmenezes requested a review from gagik April 8, 2025 13:25
Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmenezes fmenezes merged commit f1f08d4 into main Apr 8, 2025
2 checks passed
nirinchev added a commit that referenced this pull request Apr 8, 2025
* main:
  ci: publish to npm (#9)

# Conflicts:
#	dist/client.js
#	dist/config.js
#	dist/index.js
#	dist/server.js
#	dist/state.js
#	package.json
@fmenezes fmenezes deleted the ci_publish_npm branch April 30, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants