fix: updates count tool #254
Conversation
src/tools/mongodb/read/count.ts
Outdated
| query: z | ||
| .record(z.string(), z.unknown()) | ||
| .optional() | ||
| .describe("Alternative old name for filter. Will be used in db.collection.countDocuments()"), |
There was a problem hiding this comment.
is there a reason to keep providing this field?
There was a problem hiding this comment.
yes, since the LLM was already confusing query/filter, I figure that it can get confused the other way around and try to send it as "query" because it thinks we'll use .count() (even though we call out is countDocments, but who knows, it might have outdated data about MDB)
There was a problem hiding this comment.
This doesn't make much sense to me. I think we should tweak the description of filter rather than accept two arguments that are doing the same thing.
There was a problem hiding this comment.
np, I'll remove and update the description
There was a problem hiding this comment.
we can try that for now and see if it improves, based on the issue I'm not sure the LLM will stop getting confused
There was a problem hiding this comment.
I would leave that up to your testing, my (untested) intuition would be to give the LLM less options. I think it was getting confused because filter was the actual MongoDB syntax thing to do for count rather than because it found both equally valid.
There was a problem hiding this comment.
ok, I think I found a way to keep the changes here minimal. I updated the tool description, clarifying it uses .count(). I think the LLMs were getting confused, more specifically cursor, with the fact that count() is deprecated and assuming it was countDocuments under-the-hood.
* main: (21 commits) fix: updates count tool (#254) fix: docker security warnings (#259) feat: docker support (#238) docs: list alerts docs (#250) chore: add hints and update mcp (#249) chore: base model SEO change (#248) chore(ci): add a PR title check workflow (#247) docs: bump node.js version (#246) chore: corrects the description of atlas-create-db-user (#240) chore: auto-close stale issues (#237) chore(deps-dev): bump globals from 16.0.0 to 16.1.0 (#231) chore(deps-dev): bump @types/node from 22.15.9 to 22.15.17 (#233) chore(deps-dev): bump eslint-config-prettier from 10.1.2 to 10.1.5 (#234) feat: Alerts Listing (#230) chore(deps-dev): bump @redocly/cli from 1.34.2 to 1.34.3 (#235) chore(deps-dev): bump openapi-typescript from 7.6.1 to 7.8.0 (#232) chore: release v0.1.1 (#223) fix: improve uncaught exception for getAccessToken (#224) chore: update issue template (#227) chore: switch to `@mongodb-js/device-id` (#196) ...
Tests
Cursor
Claude
Windsurf