fix: validate creds #222
fix: validate creds #222
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| // For 401 errors, fall through to unauthenticated endpoint | ||
| delete headers["Authorization"]; |
There was a problem hiding this comment.
Can we ever get here? Doesn't hurt to have it just in case, but also wondering if I'm not seeing something.
There was a problem hiding this comment.
Yes, if someone sets connection string + invalid api keys, we let them start the server
There was a problem hiding this comment.
if fetch errors, we'd get here right? actually not sure
There was a problem hiding this comment.
we'd get here if we get a 401, if any other error, we do nothing
There was a problem hiding this comment.
Yeah, my point was that we need to get a 401 wrapped in a ApiClientError, which fetch shouldn't be doing, should it? The only place we can throw ApiClientError is on line 146, but that explicitly avoids throwing for 401s.
There was a problem hiding this comment.
got it! i think you're right, let me try to fix it
fixes #221