Skip to content

chore: skip Atlas Tests and don't track coverage for fork contributions #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2025

Conversation

gagik
Copy link
Collaborator

@gagik gagik commented May 2, 2025

We expose credentials in Atlas tests at the moment so we will skip them and coverage report checks for external forks and dependabot.

Because some tests get skipped, we will have coverage test issues. Instead we'll now just check
@gagik gagik requested a review from a team as a code owner May 2, 2025 10:45
@fmenezes fmenezes mentioned this pull request May 2, 2025
Copy link
Collaborator

@fmenezes fmenezes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependabot tests are not forks, let's update this here

@fmenezes fmenezes dismissed their stale review May 2, 2025 11:10

agreed offline

@fmenezes fmenezes mentioned this pull request May 2, 2025
@gagik gagik force-pushed the gagik/fix-contributions branch from 2a80d9b to 054e1c6 Compare May 2, 2025 11:40
@gagik gagik enabled auto-merge (squash) May 2, 2025 11:43
@gagik gagik merged commit c117268 into main May 2, 2025
16 checks passed
@gagik gagik deleted the gagik/fix-contributions branch May 2, 2025 11:48
nirinchev added a commit that referenced this pull request May 8, 2025
* main: (40 commits)
  chore: add more details for some api errors (#219)
  fix: use ejson parsing for stdio messages (#218)
  docs: improve getting started experience (#217)
  feat: support flex clusters to atlas tools (#182)
  chore: enforce access list (#214)
  feat: add back the connect tool (#210)
  Update connection string app name if not present (#199)
  chore: update docs with more Service Accounts mentions (#209)
  chore(deps-dev): bump eslint-plugin-prettier from 5.2.6 to 5.4.0 (#205)
  chore(deps-dev): bump @types/node from 22.15.3 to 22.15.9 (#204)
  chore(deps-dev): bump typescript-eslint from 8.31.1 to 8.32.0 (#206)
  chore(deps-dev): bump eslint from 9.25.1 to 9.26.0 (#207)
  chore: add recommended extensions and settings (#200)
  fix: fork checks (#194)
  docs: correct the link for VSCode's MCP usage (#186)
  chore: switch to a matrix for forks (#191)
  chore: skip Atlas Tests and don't track coverage for fork contributions (#188)
  fix: db user test error (#187)
  fix: improve api error messages (#176)
  chore: update quickstart with mcpServers (#185)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants