fix: add atlas instance size #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the atlas cluster listing and inspection tools to include instance size information by adding two new columns and adjusting connection string logic.
- In listClusters.ts, a new fallback for connection strings is added and instance size is derived from replication specs.
- In inspectCluster.ts, the instance size is similarly extracted and the output format is updated to include cluster type and tier.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/tools/atlas/read/listClusters.ts | Updated connection string logic; added instance size extraction and new output format |
| src/tools/atlas/read/inspectCluster.ts | Added extraction of instance size and updated the output message format accordingly |
src/tools/atlas/read/listClusters.ts
Outdated
Comment on lines
110
to
112
| const clusterInstaceType = instanceSize == "M0" ? "FREE" : "DEDICATED"; | ||
|
|
||
| return `${cluster.name} | ${clusterInstaceType} | ${clusterInstaceType == "DEDICATED" ? instanceSize : "N/A"} | ${cluster.stateName} | ${mongoDBVersion} | ${connectionString}`; |
There was a problem hiding this comment.
The variable 'clusterInstaceType' appears to be misspelled; consider renaming it to 'clusterInstanceType' for clarity.
Suggested change
| const clusterInstaceType = instanceSize == "M0" ? "FREE" : "DEDICATED"; | |
| return `${cluster.name} | ${clusterInstaceType} | ${clusterInstaceType == "DEDICATED" ? instanceSize : "N/A"} | ${cluster.stateName} | ${mongoDBVersion} | ${connectionString}`; | |
| const clusterInstanceType = instanceSize == "M0" ? "FREE" : "DEDICATED"; | |
| return `${cluster.name} | ${clusterInstanceType} | ${clusterInstanceType == "DEDICATED" ? instanceSize : "N/A"} | ${cluster.stateName} | ${mongoDBVersion} | ${connectionString}`; |
Copilot uses AI. Check for mistakes.
|
|
||
| const instanceSize = (regionConfigs.length <= 0 ? undefined : regionConfigs[0].instanceSize) || "UNKNOWN"; | ||
|
|
||
| const clusterInstaceType = instanceSize == "M0" ? "FREE" : "DEDICATED"; |
There was a problem hiding this comment.
The variable 'clusterInstaceType' appears to be misspelled; consider renaming it to 'clusterInstanceType' for clarity.
Suggested change
| const clusterInstaceType = instanceSize == "M0" ? "FREE" : "DEDICATED"; | |
| const clusterInstanceType = instanceSize == "M0" ? "FREE" : "DEDICATED"; |
Copilot uses AI. Check for mistakes.
blva
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds 2 columns to atlas-list-clusters and atlas-inspect-cluster
fixes #89