chore: defer machine ID resolution #161
Conversation
| private readonly eventCache: EventCache | ||
| ) {} | ||
|
|
||
| static create( |
There was a problem hiding this comment.
while this is not asyncronous. I'm using create(...) to make it clear there are associated side effects
gagik
force-pushed
the
gagik/use-machine-id
branch
3 times, most recently
from
f9ba638 to
2eb44fb
Compare
gagik
force-pushed
the
gagik/use-machine-id
branch
2 times, most recently
from
b78be48 to
9be3e12
Compare
gagik
force-pushed
the
gagik/use-machine-id
branch
3 times, most recently
from
5ae2584 to
5348a3a
Compare
gagik
force-pushed
the
gagik/use-machine-id
branch
from
af9631b to
c869d63
Compare
|
This has revealed a very major problem with our Build vs Jest setup targetting entirely different module resolutions... Unfortunately I can't think of a good solution... |
We did not have a full ESM configuration for jest and therefore had a discrepancy between our build vs test. This discrepancy leads to issues with CommonJS modules.
…rver into gagik/use-machine-id
…gagik/use-machine-id
| @@ -76,8 +76,6 @@ export function setupMongoDBIntegrationTest(): MongoDBIntegrationTest { | |||
| let dbsDir = path.join(tmpDir, "mongodb-runner", "dbs"); | |||
| for (let i = 0; i < 10; i++) { | |||
| try { | |||
| // TODO: Fix this type once mongodb-runner is updated. | |||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call | |||
src/deferred-promise.ts
Outdated
| resolve!: (value: T) => void; | ||
| reject!: (reason: unknown) => void; |
There was a problem hiding this comment.
Do we need the assertions here?
| resolve!: (value: T) => void; | |
| reject!: (reason: unknown) => void; | |
| resolve: (value: T) => void; | |
| reject: (reason: unknown) => void; |
There was a problem hiding this comment.
yeah, this is more of a late intialization assertion. typescript isn't smart enough to understand they're being set in the constructor
There was a problem hiding this comment.
Not sure why though - when testing locally, I don't see it complaining when I remove the assertions - in what situations are you seeing errors?
There was a problem hiding this comment.
okay I'm realizing now the assertions were leftover from an older implementation that had a different structure; removed them now. as we assert them later on instead.
gagik
changed the title
src/deferred-promise.ts
Outdated
| resolve!: (value: T) => void; | ||
| reject!: (reason: unknown) => void; |
There was a problem hiding this comment.
Not sure why though - when testing locally, I don't see it complaining when I remove the assertions - in what situations are you seeing errors?
gagik
force-pushed
the
gagik/use-machine-id
branch
from
25d9059 to
8816bef
Compare
Fixes #122
This defers the device ID resolution and add a timeout for resolution. Buffers events in the meantime.