Skip to content

chore: add testing to native SSL hooks #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

nbbeeken
Copy link
Collaborator

Description

What is changing?

  • Adds testing to cover with and without openssl 3 and across all OSes and major node versions
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Testing the crypto hook change.

The testing is light, focused on getting the infra working.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken changed the title NODE-5455-testing-ssl chore: add testing to native SSL hooks Jun 25, 2024
@nbbeeken nbbeeken merged commit 2b1e462 into 5455-openssl-native-hooks Jun 26, 2024
@nbbeeken nbbeeken deleted the NODE-5455-testing-ssl branch June 26, 2024 19:31
nbbeeken added a commit that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant