feat: add device ID hashing package COMPASS-8443 #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
force-pushed
the
gagik/add-hashing-lib
branch
2 times, most recently
from
d8105db to
c0b5e18
Compare
addaleax
approved these changes
May 2, 2025
| } else { | ||
| resolve('unknown'); | ||
| } | ||
| }, timeout); |
There was a problem hiding this comment.
Suggested change
| }, timeout); | |
| }, timeout).unref?.(); |
gagik
force-pushed
the
gagik/add-hashing-lib
branch
2 times, most recently
from
c344e1c to
db019bb
Compare
gagik
force-pushed
the
gagik/add-hashing-lib
branch
from
db019bb to
115f688
Compare
|
There seems to be some unrelated SBOM dependency failing issue; going ahead with merge. |
This was referenced May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a consistent, implementation-agnostic hash from a given raw machine ID. The machine ID should originate from
node-machine-idornative-machine-iddepending on the platform. The hash is generated using SHA-256 and is designed to be consistent with the Atlas CLI.