Skip to content

remove import bootstrap from apps that can support it #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions basic-host-remote/app1/src/bootstrap.js

This file was deleted.

6 changes: 5 additions & 1 deletion basic-host-remote/app1/src/index.js
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
import("./bootstrap");
import App from "./App";
import React from "react";
import ReactDOM from "react-dom";

ReactDOM.render(<App />, document.getElementById("root"));
7 changes: 7 additions & 0 deletions basic-host-remote/app2/src/App.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
// have to have a promise (import()) somewhere for exposed code
// you can either use import bootstrap, like i do here
// or if you dont like import(bootstrap) you can get rid of that but need to import like

// this like here: const LocalButton = React.lazy(()=>import('./Button'));
// then you can remove the need for import(bootstrap)
//https://github.com/webpack/webpack/issues/10352#issuecomment-622016042
import LocalButton from "./Button";
import React from "react";

Expand Down
1 change: 1 addition & 0 deletions basic-host-remote/app2/src/index.js
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
// https://github.com/webpack/webpack/issues/10352#issuecomment-622016042
import("./bootstrap");
5,453 changes: 0 additions & 5,453 deletions comprehensive-demo/yarn.lock

This file was deleted.

2 changes: 1 addition & 1 deletion proprietary-tools
Loading