Skip to content

Fix OAuth metadata validation for compliant servers #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mcp/shared/auth.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class OAuthMetadata(BaseModel):
list[Literal["authorization_code", "refresh_token"]] | None
) = None
token_endpoint_auth_methods_supported: (
list[Literal["none", "client_secret_post"]] | None
list[Literal["none", "client_secret_post", "client_secret_basic"]] | None
) = None
token_endpoint_auth_signing_alg_values_supported: None = None
service_documentation: AnyHttpUrl | None = None
Expand All @@ -134,4 +134,4 @@ class OAuthMetadata(BaseModel):
list[Literal["client_secret_post"]] | None
) = None
introspection_endpoint_auth_signing_alg_values_supported: None = None
code_challenge_methods_supported: list[Literal["S256"]] | None = None
code_challenge_methods_supported: list[Literal["S256", "plain"]] | None = None
Loading