Fix flaky WebFluxSse integration test #238
Merged
+24
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WebFluxSseIntegrationTests.testLoggingNotification
test is flaky and can fail with:When running this test in the IDE with 100 times (with 2 test params it means 200 runs) repeat mode, it can take 25s in the optimistic variant on my machine and occasionally fails for the JDK HttpClient variant.
With this change, repeating 100 times finishes in 4s. It essentially avoids using awaitility and instead relies on a
CountDownLatch
to coordinate completion. The flakiness comes from the fact that the results are aggregated in anArrayList
, which can fail to publish the results coming from asynchronous sources. The replacement used is aCopyOnWriteArrayList
.