Enable IsAotCompatible for ModelContextProtocol.AspNetCore #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
If we registered McpJsonUtilities.DefaultOptions.TypeInfoResolver with JsonOptions.SerializerOptions in an IConfigureOptions<JsonOptions> service added as part of a new AddAspNetCoreMcpServer(this IServericeCollection method, we could simplify this to context.Request.ReadFromJsonAsync<IJsonRpcMessage>(context.RequestAborted) which is also AotCompatible.
But for now, I like not needing any ASP.NET Core specific services to use MapMcp.
| @@ -9,6 +9,7 @@ | |||
| <PackageId>ModelContextProtocol.AspNetCore</PackageId> | |||
| <Description>ASP.NET Core extensions for the C# Model Context Protocol (MCP) SDK.</Description> | |||
| <PackageReadmeFile>README.md</PackageReadmeFile> | |||
| <IsAotCompatible>true</IsAotCompatible> | |||
There was a problem hiding this comment.
Have we similarly turned on <PublishAOT> on the sample projects consuming this?
There was a problem hiding this comment.
None of our samples enable it. I believe @agocke was offering to help do so... Andy?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.