-
Notifications
You must be signed in to change notification settings - Fork 231
dont cache if model::$isCachable == false #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
<?php | ||
|
||
namespace GeneaLabs\LaravelModelCaching; | ||
|
||
use Illuminate\Database\Eloquent\Builder as EloquentBuilder; | ||
use Illuminate\Database\Eloquent\Model; | ||
|
||
class QueryOrModelCaller | ||
{ | ||
/** | ||
* @var CachedBuilder | ||
*/ | ||
protected $query; | ||
/** | ||
* @var Model | ||
*/ | ||
protected $model; | ||
/** | ||
* @var bool | ||
*/ | ||
protected $disableInConfig; | ||
|
||
/** | ||
* QueryOrModelCaller constructor. | ||
* | ||
* @param EloquentBuilder $query | ||
* @param Model $model | ||
* @param bool $disableInConfig | ||
*/ | ||
public function __construct(EloquentBuilder $query, Model $model, bool $disableInConfig) | ||
{ | ||
$this->query = $query; | ||
$this->model = $model; | ||
$this->disableInConfig = $disableInConfig; | ||
} | ||
|
||
/** | ||
* @param $name | ||
* @param $arguments | ||
* | ||
* @return mixed | ||
*/ | ||
public function __call($name, $arguments) | ||
{ | ||
if ($name == 'all') | ||
$result = call_user_func_array([$this->model, 'all'], $arguments); | ||
else | ||
$result = call_user_func_array([$this->query, $name], $arguments); | ||
|
||
config()->set('laravel-model-caching.disabled', $this->disableInConfig); | ||
|
||
return $result; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that
isCachable
can never be set for theall()
method, since settingisCachable
is set through a query scope, which returns a Builder object, which doesn't have an all method. Consider that the following code throws an exception:Unfortunately the only way to disable caching on
all()
queries is to turn it off in config at this point, or change toget()
. Perhaps you have some thoughts on how we can disable the cache on the model? In the past, I've had a method on the model, instead of a scope, and that had more problems than it solved, so I moved to scope.