Add support for withoutGlobalScopes #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gitwilliam Thank you so much for all the work you put into this! I will review and merge by the end of this weekend and release a new version if everything is working. :) |
Thanks for looking at it @mikebronner. I fully admit that there are still a lot of things about the library that I don't understand. So feel free to send me off to correct anything you think is not in keeping with design or intention. |
mikebronner
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention of this PR is to add in support for the
withoutGlobalScopeandwithoutGlobalScopesfunction in Eloquent (https://laravel.com/docs/8.x/eloquent#removing-global-scopes).When an application using the Caching Library applies the
withoutGlobalScopes()modifier to a model, the global scopes are currently being added back in by the Caching Library. This requires the client application to disable the cache,disableCache(), prior to callingwithoutGlobalScopes. This PR should fix that.