Add some code to stop scopes from being applied twice. #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est for this as well.
|
@saernz Thanks so much for this, this is awesome! I will take a look first thing in the morning. |
mikebronner
reviewed
Jul 2, 2020
| */ | ||
| public function applyScopes() | ||
| { | ||
| if ($this->scopesAreApplied) { |
There was a problem hiding this comment.
@saernz Quick question: where is $this->scopesAreApplied defined or updated when scopes are applied? I couldn't find it when doing a global search.
There was a problem hiding this comment.
Oh, nevermind, I found it in Caching.php ... sorry, overlooked that earlier.
|
@mikebronner Thanks for the merge man! That's weird there was that compatibility issue that the tests didn't pick up, thanks for fixing it all up. |
|
I think it was because the tests weren't triggering the case where the scopes weren't applied yet. Will experiment with that a bit and see if we can't get a test to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #289 by overriding the builders implementation of
applyScopes()to make it check if scopes have been applied already before attempting to apply them again.