Skip to content

Recreate baseline sqlite db once per test suite run #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2020
Merged

Recreate baseline sqlite db once per test suite run #337

merged 4 commits into from
Apr 15, 2020

Conversation

dmason30
Copy link
Contributor

@dmason30 dmason30 commented Apr 14, 2020

So this removes the sqlite files from version and it will recreate the baseline.sqlite once on each run so the first test will always appear slower than it is because it is seeding the database.

Also because the IntegrationTestCase uses the Orchestra/TestCase and the FeatureTestCase uses the Orchestra/BrowserKit/TestCase that means that each of those recreates the baseline.sqline once for each.

I don't think the time penalty of a second per run is that bad for consistent test runs.

Its hard to explain clearly but I hope you understand.

@dmason30 dmason30 changed the title Recreate baseline sqlite db on each test run Recreate baseline sqlite db once per test suite run Apr 14, 2020
@mikebronner mikebronner merged commit 4c0013b into mikebronner:master Apr 15, 2020
@dmason30 dmason30 deleted the baseline-test-migration branch April 15, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants