Recreate baseline sqlite db once per test suite run #337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this removes the sqlite files from version and it will recreate the
baseline.sqlite
once on eachrun
so the first test will always appear slower than it is because it is seeding the database.Also because the
IntegrationTestCase
uses theOrchestra/TestCase
and theFeatureTestCase
uses theOrchestra/BrowserKit/TestCase
that means that each of those recreates thebaseline.sqline
once for each.I don't think the time penalty of a second per run is that bad for consistent test runs.
Its hard to explain clearly but I hope you understand.