Skip to content

Handle json contains with array value #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Handle json contains with array value #325

merged 1 commit into from
Apr 9, 2020

Conversation

dmason30
Copy link
Contributor

@dmason30 dmason30 commented Apr 9, 2020

Fixes #319

@mikebronner
Copy link
Owner

@dmason30 Awesome, thank you so much for taking the initiative here and fixing this! :)

@mikebronner mikebronner merged commit 13fcd1a into mikebronner:master Apr 9, 2020
@dmason30
Copy link
Contributor Author

dmason30 commented Apr 9, 2020

@mikebronner No problem I might come up with a few more I was using this at my job before the pandemic. Currently furloughed so when I am not decorating I might as well do some OSS contributions ;)

@mikebronner
Copy link
Owner

Much appreciated, for sure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return value of GeneaLabs\LaravelModelCaching\CacheKey::getValuesFromWhere() must be of the type string, array returned
2 participants