Skip to content

Add column-based where test #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2017
Merged

Add column-based where test #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0524cd
fixing case of method name
Oct 15, 2017
84092bb
adding test for where column parsing
Oct 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions tests/Unit/CachedBuilderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ public function testValueModelResultsCreatesCache()
$this->assertEquals($liveResults, $cachedResults);
}

public function testNestedRelationshipEagerloading()
public function testNestedRelationshipEagerLoading()
{
$authors = collect([(new Author)->with('books.publisher')
->first()]);
Expand Down Expand Up @@ -510,8 +510,19 @@ public function testExistsRelationshipWhereClauseParsing()

public function testColumnsRelationshipWhereClauseParsing()
{
// ???
$this->markTestIncomplete();
$author = (new Author)->orderBy('name')->first();

$authors = collect([(new Author)->where('name', '=', $author->name)->first()]);

$key = 'genealabslaravelmodelcachingtestsfixturesauthor-name_' . $author->name . '-first';
$tags = ['genealabslaravelmodelcachingtestsfixturesauthor'];

$cachedResults = collect([cache()->tags($tags)->get($key)]);

$liveResults = collect([(new UncachedAuthor)->where('name', '=', $author->name)->first()]);

$this->assertEmpty($authors->diffAssoc($cachedResults));
$this->assertEmpty($liveResults->diffAssoc($cachedResults));
}

public function testRawWhereClauseParsing()
Expand Down