Fix never forget cooldown seconds in checkCooldownAndRemoveIfExpired. #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for posting a possible solution! :) I will take a look at this, hopefully this weekend. I'm pretty swamped at the moment with another project, so can't make any concrete promises. |
|
@mikebronner Can you review this PR in this week? |
|
I will try. I am currently working on Laravel 5.8 compatibility and will review the PRs after that. |
|
yea, that was a copy/paste issue, thanks for finding that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I execute
${cachableModel}->scopeWithCacheCooldownSeconds.But
cooldown secondsnever been changed.So, I found this problem in
Caching::checkCooldownAndRemoveIfExpired.(Maybe copy and paste code but not changed from
cooldown:invalidated-attocooldown:seconds?)