Multiple Database Connections: Extension #120
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed the connection name to the database name. This would be more flexible if a tenant system use for every tenant the same connection name and only changed the database in the connection. This change has no disadvantages compared to the previous variant
|
I'm not sure if the problems result in this change? |
|
Yes, the failures are directly related to this PR. I do have plans to add the database name to the cache key, but keeping the connection name is critical as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the connection name to the database name. This would be more flexible if a tenant system use for every tenant the same connection name and only changed the database in the connection.
This change has no disadvantages compared to the previous variant