Skip to content

consider changing MODEL_CACHE_DISABLED to MODEL_CACHE_ENABLED #266

Closed
@vesper8

Description

@vesper8

this is a bit nitpicky but the thing is every other package that I've ever used that can be disabled via the config uses a SOMETHING_ENABLED format

Laravel Telescope, Laravel Debugbar, Laravel ResponseCache to name a few

Yours is the opposite and it's just not very intuitive IMHO and just now confused me as I meant to disable it while debugging a problem and didn't immediately realize I had to use the opposite boolean for your package

Possibly you could support the new key while still also supporting the old one. Or rename the key in a new major version.. Food for thought

Metadata

Metadata

Assignees

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions