Polymorphic relationships error out when caching is enabled.

[smapod]

I updated LMC from 0.3.6 to 0.4.14, and morph relationships broke.

Explanation:

1. I call php artisan cache:clear to clear cache.
2. I get products and their prices using eager-load for the first time, everything is fine.

3. I get other products and their prices, the query to the database is cached and not displayed in the console, of course cache doesn't have this data - relationships is not returned.

Expecting missed query:

Product model:

Price model:

In 0.3.6 all worked fine.

[mikebronner]

@smapod Thanks for reporting this. I will look into this over the next few days.

[mikebronner]

@smapod Can you provide your eloquent query that uses the morph? This will help me create a test case. (I realize you provided the SQL query above, but the eloquent code is really what we need to troubleshoot this.) Also, if you could provide the model that defines the morphTo relationship, that would help as well. Thanks!

[smapod]

@mikebronner thank you for your answer.

Models:

<?php

namespace App\Models;

use GeneaLabs\LaravelModelCaching\Traits\Cachable;
use Illuminate\Database\Eloquent\Model;

class Product extends Model
{
    use Cachable;

    protected $fillable = [
        'title', 'category_id'
    ];

    public function price()
    {
        return $this->morphOne(Price::class, 'priceable');
    }
}

<?php

namespace App\Models;

use GeneaLabs\LaravelModelCaching\Traits\Cachable;
use Illuminate\Database\Eloquent\Model;

class Price extends Model
{
    use Cachable;

    protected $fillable = ['priceable_id', 'priceable_type', 'price'];

    public function priceable()
    {
        return $this->morphTo();
    }
}

I also have morphMap:

\Illuminate\Database\Eloquent\Relations\Relation::morphMap([
    'product' => Product::class
]);

Schemas:

Schema::create('products', function (Blueprint $table) {
    $table->bigIncrements('id');
    $table->string('title');
    $table->integer('category_id');
    $table->timestamps();
});

Schema::create('prices', function (Blueprint $table) {
    $table->bigIncrements('id');
    $table->string('priceable_type');
    $table->bigInteger('priceable_id');
    $table->float('price');
    $table->timestamps();
});

Seed products with category_id = 1 and category_id = 2 and their prices. After that try this queries:

$products = Product::with(['price'])
    ->where('category_id', 1)
    ->paginate(50);

$products = Product::with(['price'])
    ->where('category_id', 2)
    ->paginate(50);

First query will return products with filled price relation, second will return products with empty price relation.

[smapod]

@mikebronner Corrected the answer.

[mikebronner]

@smapod awesome, thanks for the additional details. I will try to look into this over the next few days.

[mikebronner]

Likely related to #225

[mikebronner]

@smapod can you test this again with version 0.4.15? I have a feeling the whereIn fix might also have fixed this. Please let me know how it works. Thanks!