Same results for different queries using whereRaw with added bindings

[emielmolenaar]

Issue

I get the same results for different queries using whereRaw with added bindings when called on the same column. For example:

SomeModel::whereRaw('somecolumn = ?', ['somevalue'])->get();
SomeModel::whereRaw('somecolumn = ?', ['anothervalue'])->get();
SomeModel::whereRaw('somecolumn = ?', ['yetanothervalue'])->get();

The second and third query always returns the result of the first query.

I did dug around in the code. I noticed that CacheKey does not include the value of the binding given to the whereRaw method. This results in a string that is the same for these three queries, thus causing trouble.

I guess adding a $this->getValuesClause($where) to https://github.com/GeneaLabs/laravel-model-caching/blob/master/src/CacheKey.php#L172 should fix the problem? Haven't been able to spend much time on it so please correct me if I'm wrong or if this will break stuff. I am willing to create a PR to fix this!

Environment

Laravel Version: 5.6.16
Laravel Model Caching Package Version: 0.2.52
PHP Version: 7.2.2
Homestead Version: n/a
Operating System & Version: Debian 9.3

[mikebronner]

Thanks for submitting this! :) I will take a look at this as soon as I can. :) I think your suspicions sound about right.

[mikebronner]

Please try release 0.2.54 or greater -- that should have fixed it. Please let me know. :) And thanks for being patient!

[emielmolenaar]

Thanks @mikebronner ! Handling raws is going better now, except when they are in a nested where 😃

ErrorException: Undefined offset: 6 in vendor/genealabs/laravel-model-caching/src/CacheKey.php:192

#2 vendor/genealabs/laravel-model-caching/src/CacheKey.php(152): GeneaLabs\LaravelModelCaching\CacheKey->getRawClauses(Array)
#3 [internal function]: GeneaLabs\LaravelModelCaching\CacheKey->GeneaLabs\LaravelModelCaching\{closure}('-_or_LOWER(`ass...', Array)
#4 vendor/laravel/framework/src/Illuminate/Support/Collection.php(1313): array_reduce(Array, Object(Closure), NULL)
#5 vendor/genealabs/laravel-model-caching/src/CacheKey.php(156): Illuminate\Support\Collection->reduce(Object(Closure))
#6 vendor/genealabs/laravel-model-caching/src/CacheKey.php(167): GeneaLabs\LaravelModelCaching\CacheKey->getWhereClauses(Array)
#7 vendor/genealabs/laravel-model-caching/src/CacheKey.php(150): GeneaLabs\LaravelModelCaching\CacheKey->getNestedClauses(Array)
#8 [internal function]: GeneaLabs\LaravelModelCaching\CacheKey->GeneaLabs\LaravelModelCaching\{closure}(NULL, Array)
#9 vendor/laravel/framework/src/Illuminate/Support/Collection.php(1313): array_reduce(Array, Object(Closure), NULL)
#10 vendor/genealabs/laravel-model-caching/src/CacheKey.php(156): Illuminate\Support\Collection->reduce(Object(Closure))
#11 vendor/genealabs/laravel-model-caching/src/CacheKey.php(36): GeneaLabs\LaravelModelCaching\CacheKey->getWhereClauses()
#12 vendor/genealabs/laravel-model-caching/src/Traits/Caching.php(75): GeneaLabs\LaravelModelCaching\CacheKey->make(Array, NULL, '')
#13 vendor/genealabs/laravel-model-caching/src/CachedBuilder.php(77): GeneaLabs\LaravelModelCaching\CachedBuilder->makeCacheKey(Array)

I can reproduce this issue this way:

SomeModel::select(['column1', 'column2', 'column3', 'column4', 'column5', 'column6'])->where(function($where) { 
  $where->orWhereRaw('column1 LIKE ?', [$somevar]);
  $where->orWhereRaw('column2 LIKE ?', [$somevar]);
  $where->orWhereRaw('column3 LIKE ?', [$somevar]);
  $where->orWhereRaw('column4 LIKE ?', [$somevar]);
  $where->orWhereRaw('column5 LIKE ?', [$somevar]);
  $where->orWhereRaw('column6 LIKE ?', [$somevar]);
});

I don't think $this->currentBinding++; is required in getNestedClauses() ?

[Marcuzz]

As far as I can tell I see no use for $this->currentBinding++; in getNestedClaused() as it completely breaks getRawClauses() as you're using the same variable there - can we get this patched? Other than that 0.2.54 fixed the issue

[mikebronner]

@Marcuzz can you check if this was fixed in 0.2.55 ... there were some issues I fixed from 0.2.54. Thanks!

[Marcuzz]

@mikebronner It is not, it's still an issue in 0.2.55 as that's the version I tested this on, thanks

[mikebronner]

Thanks, will take a look -- I know there were other issues with nested where clauses. Will try to fix both over the next few days.

[mikebronner]

@emielmolenaar I am unable to recreate the issue. Running select() on a model has no effect, it's really only useful on querybuilders, and not on eloquentquerybuilders.

The code you proveded above returns an instance of eloquentquerybuilder, and not a a result as such. Could you provide a working example that reproduces the issue? That would help tremendously! Thanks!