Feature: National Cloud Support #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rosoftgraph/msgraph-sdk-powershell into feature/NationalCloudSupport
|
does Remove-MgEnvironment allow removing our default environments? |
ddyett
reviewed
Oct 12, 2020
ddyett
reviewed
Oct 12, 2020
ddyett
reviewed
Oct 12, 2020
ddyett
reviewed
Oct 12, 2020
|
@ddyett We guard against that. An error will be thrown when a customer tries to remove or modify built-in environments. |
ddyett
reviewed
Oct 12, 2020
Co-authored-by: DeVere Dyett <ddyett@microsoft.com>
ddyett
reviewed
Oct 12, 2020
src/Authentication/Authentication/Cmdlets/Environment/SetMgEnvironment.cs
Outdated
Show resolved
Hide resolved
ddyett
reviewed
Oct 12, 2020
ddyett
reviewed
Oct 12, 2020
ddyett
reviewed
Oct 12, 2020
ddyett
reviewed
Oct 12, 2020
ddyett
reviewed
Oct 12, 2020
ddyett
reviewed
Oct 12, 2020
src/Authentication/Authentication/Common/ProtectedFileProvider.cs
Outdated
Show resolved
Hide resolved
ddyett
reviewed
Oct 12, 2020
ddyett
approved these changes
Oct 13, 2020
georgend
approved these changes
Oct 14, 2020
3 tasks
This was referenced Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #357 #93 #260 by proposing the following changes:
Get-MgEnvironment,Set-MgEnvironment,Add-MgEnvironment, andRemove-MgEnvironmentcommands to manage cloud environments.Add-MgEnvironmentcan be used to add air-gapped clouds such as canary.-Environmentparameter toConnect-MgGraph. This parameter will be used to switch to a cloud of choice by providing its name. This defaults toGlobalif none is specified.GraphSettings,DiskDataStoreandProtectedFileProviderto handle settings persistence on disk in a thread safe manner.AuthenticationHelpers.csto construct an authority URL based on the selected cloud.Invoke-GraphRequestto work in harmony withConnect-MgGraph -Environment.Proposed Usage
List available environments (
Get-MgEnvironment)Add user-defined environment (
Add-MgEnvironment)Connect to environment/cloud (
Connect-MgGraph -Environment)Remove user-defined environment (
Remove-MgEnvironment).Open questions