Skip to content

fix bug to return empty array when no config exists #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ export function getConfigurationsFromSettings(workspace: WorkspaceFolder): Debug
!Array.isArray(codeWorkspaceConfig.configurations) ||
codeWorkspaceConfig.configurations.length === 0
) {
throw Error('No configurations found in launch.json or settings.json');
traceLog('No configurations found in settings.json or launch.json.');
return [];
}
traceLog('Using configuration in workspace settings.json.');
return codeWorkspaceConfig.configurations;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ suite('Debugging - launchJsonReader', () => {
assert.strictEqual(configurations[0].name, 'Launch Program 3');
});

test('Should error if no configurations in settings.json', () => {
test('Should return empty array if no configurations in settings.json', () => {
const workspace = typemoq.Mock.ofType<WorkspaceFolder>();
workspace.setup((w) => w.uri).returns(() => Uri.file('/path/to/workspace'));

Expand All @@ -106,11 +106,8 @@ suite('Debugging - launchJsonReader', () => {

sandbox.stub(vscodeapi, 'getConfiguration').returns(mockConfig.object);

assert.throws(
() => getConfigurationsFromSettings(workspace.object),
Error,
'No configurations found in launch.json or settings.json',
);
const configurations = getConfigurationsFromSettings(workspace.object);
assert.strictEqual(configurations.length, 0);
});
});
});