This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Use a null package for string_decoder #1524
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing CG for string_decoder:
The only purpose for string_decoder was to support old versions of node, and isn't actually needed/used for modern versions of node/electron at all.
Unfortunately, you can't delete a dependency using overrides in the package.json file -- you can only point to a different version (or directly to a package file)
I created a string_decoder 10.0.0 package file, and add that to the overrides, and it appears that everything works.
The trouble is, that the path to the string_decoder-10.0.0.tgz has to be absolute (either on disk, or a URL to a location on the web)
I don't want a whole repo to create a string_decoder placeholder, so I just created a simple package and put it in the assets of the latest pre-release and took the direct-link to that and put it into the package.json overrides section:
and then removed the package-lock files and did an NPM install and it works, and the vscode tests pass