This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Fix line-oriented callbacks #1494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdoutcb/stderrcb assume that an input string is a single line, but in fact it can contain multiple lines, or even be a part of a line. One of the consequence is that cocopa fails to parse compiler output when it contains long lines (microsoft#1275). This patch fixes the issue by introducing a buffer to accumulate received data before passing them to callbacks. Fixes microsoft#1275.
|
|
|
I'm checking with my employer if I can sign the CLA. |
|
Signed CLA. |
|
/azp run |
benmcmorran
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
Thanks for the contribution @nya3jp! I pushed one small change to avoid n^2 runtime on long lines, but otherwise this looks good to me. Any more comments you may see are just me convincing our internal CI systems to test this PR.
|
/azp run |
|
@benmcmorran I overlooked the O(n^2) issue, thanks for catching it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stdoutcb/stderrcb assume that an input string is a single line, but in fact it can contain multiple lines, or even be a part of a line.
One of the consequence is that cocopa fails to parse compiler output when it contains long lines (#1275).
This patch fixes the issue by introducing a buffer to accumulate received data before passing them to callbacks.
Fixes #1275.