This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Change node serial to new serial cli #1322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add gulp task to consume serial-monitor-cli artifacts
adiazulay
requested review from
dilin-MS and
aleun
and removed request for
dilin-MS
aleun
approved these changes
Aug 20, 2021
| port: string; | ||
| desc: string; | ||
| hwid: string; | ||
| vendorId: string; |
There was a problem hiding this comment.
ISerialPortDetail here should be replaced with the definition of the same name in serialportctrl.ts.
| }); | ||
| } | ||
| }); | ||
| resolve(true); |
There was a problem hiding this comment.
I believe resolve should not be called here, but called in a handler for the spawn event to prevent a race that resolves the promise before the error event is emitted.
| this._outputChannel.show(); | ||
|
|
||
| if (this._child) { | ||
| this._child.stdin.write("close\n"); |
There was a problem hiding this comment.
I think this message needs to be wrapped in JSON. I might suggest just wrapping this logic into a closeChildProcess method and reuse that, since I see this same pattern in a few places in this class.
Suggested change
| this._child.stdin.write("close\n"); | |
| this._child.stdin.write('{"cmd": "close"}\n'); |
adiazulay
added a commit
that referenced
this pull request
Aug 26, 2021
* change to dev branch (#1323) * Change node serial to new serial cli (#1322) * add args to build * initial integration of serial cli * Add gulp task for serial-monitor-cli insertion * Temporarily disable serial monitor insertion task * Uncomment task * change platforms to match os.platform * fix linting * add relative path for serial Co-authored-by: Alan Leung <alleu@microsoft.com> * Add fixes from code review (#1328) * remove native serial dependencies * fixes from code review * Revert "remove native serial dependencies" This reverts commit 6586a66. * add vid pid support * code review fixes * revert stop to return bool * pre release v0.4.4-rc1 * bump to 0.4.4-rc2 * bump to v0.4.4 Co-authored-by: Alan Leung <alleu@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changing away from the node serial package to avoid serial breaking any time electron updates.