Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

Initialize VSCode extension for Arduino. #1

Merged
merged 1 commit into from
Dec 30, 2016
Merged

Initialize VSCode extension for Arduino. #1

merged 1 commit into from
Dec 30, 2016

Conversation

yaohaizh
Copy link
Contributor

@msftclas
Copy link

Hi @yaohaizh, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Yaohai Zheng). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


# Tab indentation
[*]
indent_style = tab
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why using tab instead of space here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy from VSCode/go-vscode styles. Will use space as agreed.

Copy link
Member

@akaroml akaroml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Just the coding style of using tab instead of space. I remember we had a vote inside the team. And space was preferred.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants