This repository was archived by the owner on Oct 1, 2024. It is now read-only.
This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Express server is started on random port when vscode-arduino is activated #966
Open
Description
VSCode info
Version: 1.41.1
Commit: 26076a4de974ead31f97692a0d32f90d735645c0
Date: 2019-12-20T11:11:01.597Z
Electron: 6.1.7
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Linux x64 5.5.2-arch2-2
Extension version
0.2.29
Description:
A random port is opened on the machine on which the extension is running, with an Express server listening. The opened port is available form other hosts on the same network.
Steps to reproduce (linux host) :
- install extension
- run
sudo netstat -tulpan | grep LISTENand note the port (here 44873)
tcp6 0 0 :::44873 :::* LISTEN 16511/electron
- run
curl localhost:44873(replacing 44873 with port noted in 2.
<html>
<head>
<style title="themestyle"> </style>
<script type="text/javascript">
// inherit theme styles from vscode ide
var decode = function (s) {
return decodeURIComponent(s.replace(/\+/g, " "));
};
var getStyleSheet = function (unique_title) {
for(var i=0; i<document.styleSheets.length; i++) {
var sheet = document.styleSheets[i];
if(sheet.title == unique_title) {
return sheet;
}
}
};
var match,
search = /([^&=]+)=?([^&]*)/g,
query = window.location.search.substring(1),
queryParams = {};
while (match = search.exec(query)) {
queryParams[decode(match[1])] = decode(match[2]);
}
var supportedThemes = ["vscode-dark", "vscode-light"];
var theme = "vscode-dark"; // default theme.
if (supportedThemes.indexOf(queryParams["theme"]) > -1) {
theme = queryParams["theme"];
}
var bgcolor = queryParams["backgroundcolor"];
var color = queryParams["color"];
var stylesheet = getStyleSheet("themestyle");
stylesheet.insertRule(".vscode-theme { background-color: " + bgcolor + "; color: " + color + "; }", 0);
stylesheet.insertRule(".vscode-theme .theme-bgcolor { background-color: " + bgcolor + "; }", 1);
stylesheet.insertRule(".vscode-theme .theme-color { color: " + color + "; }", 2);
stylesheet.insertRule("html > body { background-color: " + bgcolor + "; color: " + color + "; }", 3);
document.documentElement.className = theme + " vscode-theme";
</script>
<link href="styles/app.css" rel="stylesheet"></head>
<body>
<div id="mainContent"></div>
<script type="text/javascript" src="app.js"></script></body>
</html>
- disable extension
- run
sudo netstat -tulpan | grep LISTENagain
nothing
Expected behavior
No port is opened, or at least opened on a local only mode.
Culprit seems to be this file : https://github.com/microsoft/vscode-arduino/blob/master/src/arduino/localWebServer.ts