Plugin appends 'Arduino.app' to path on MacOS

[recursivecodes]

Why?

If I'm using the CLI, I put /Users/bin/ and arduino-cli for the command path, but it ends up looking in /Users/bin/Arduino.app/arduino-cli. If I'm trying to use the CLI, it should not append anything to the path like that.

vscode-arduino/src/common/sys/darwin.ts

Line 13 in 3bb7b14

if (directoryExistsSync(path.join(scanPath, "Arduino.app"))) {

[recursivecodes]

Any thoughts on this?

[awmichel]

@recursivecodes I ran into the same issue and I believe the PR I just opened #1227 resolves this issue. I'm not too familiar with VSCode extension development, so I'm not sure about the steps to install an extension from a git repo, but I manually edited the source in ~/.vscode/extensions/vsciot-vscode.vscode-arduino-0.4.0/out/src/ to test out my changes.

[adiazulay]

Thanks @awmichel for fixing this!

@recursivecodes this was an artifact of how the extension would handle accessing the IDE in older builds.

[adiazulay]

This should be fixed in v0.4.1. @awmichel do you mind giving this a testing it out and letting me know if it works?
https://github.com/microsoft/vscode-arduino/releases/tag/v0.4.1-rc1

[awmichel]

@adiazulay Installed 0.4.1-rc1 locally and was able to verify and upload to a ESP32 using arduino-cli.

For anyone else using a MacOS M1 w/ arduino-cli installed via Homebrew, your VSCode settings should look something like:

{
    "arduino.useArduinoCli": true,
    "arduino.path": "/opt/homebrew/bin/",
    "arduino.commandPath": "arduino-cli",
}

On a non-M1 Mac (untested):

{
    "arduino.useArduinoCli": true,
    "arduino.path": "/usr/local/bin/",
    "arduino.commandPath": "arduino-cli",
}