Output strings are garbled in Japanese environment

[HiroTamori]

version 0.3.5 (this bug occurred at least 0.3.4 too)
on Windows 10 (Build 1909) Japanese edition

Workaround is comment the line 215 of out/src/common/util.js out;

        const child = childProcess.spawn(command, args, options);
        let codepage = "65001";
/*
        if (os.platform() === "win32") {
            try {
                const chcp = childProcess.execSync("chcp.com");
                codepage = chcp.toString().split(":").pop().trim();
            }
            catch (error) {
                outputChannel_1.arduinoChannel.warning(`Defaulting to code page 850 because chcp.com failed.\
                \rEnsure your path includes %SystemRoot%\\system32\r${error.message}`);
                codepage = "850";
            }
        }
*/
        if (outputChannel) {
            child.stdout.on("data", (data) => {

(Thanks nori-dev-akg san on the article)

This code seems to change UTF-8(codepage 65001) strings to Shift-JIS or something even it is not required by vscode.

[Tnze]

duplicated : #875, #958, #1096

[two-pack]

PR #1237 fixed this problem on my environment.
It was already closed but not merged :(

[Tnze]

But why

[two-pack]

PR #1237 fixed this problem on my environment.
It was already closed but not merged :(

I calmed myself down and checked again.

PR #364 in vscode-arduino added converting using chcp.com command on 13 Jul 2017.
Probably that time, incorrect characters, caused Arduino that output ansi codepage, was fixed.

PR #8289 in arduino/Arudino added encoding config of compiler log to arduino.l4j.ini. After that, Arduino outputs UTF-8 codepage by default.
Probably that time, incorrect characters, caused Arduino that output UTF-8 codepage, was occured again.

PR #1237 specifies the code page as fixed to UTF-8, so the correct characters are output.
But now I think better solution is reverting #364 because default log codepage is UTF-8 on latest Arduino. Or #1271.

[benmcmorran]

This issue should be fixed by PR #1271 which has merged and will be included in the next release of this extension. If you'd like to test the changes before they are released, you can download and install the build artifact.

[github-actions]

This issue has been fixed in the latest release of this extension, which is available in the VS Code extension marketplace.