Use canHaveFlowNode
in checkIfExpressionRefinesParameter
#1145
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the changes from microsoft/TypeScript#58816 to the Go implementation.
TypeScript Change Summary
The original TypeScript change replaced a type assertion pattern:
with a proper type guard function:
Go Change Summary
In Go, this translates to replacing
getFlowNodeOfNode(expr)
with an explicitcanHaveFlowNode
check pattern:Before:
After:
This change improves code clarity by using the explicit type guard function
canHaveFlowNode
instead of relying on the internal helpergetFlowNodeOfNode
, making the code more consistent with the TypeScript implementation style.The semantics remain exactly the same - both approaches check if the node has flow node data and extract it if available, but the new approach is more explicit and matches the TypeScript codebase pattern.
✅ All tests pass and build succeeds
Fixes #1129.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.