Skip to content

[WIP] Port TypeScript PR #59675: fix(59397): JsDoc is missing/duplicated in declarations for overloads declared in classes declared in functions #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Copilot
Copy link

@Copilot Copilot AI commented Jun 10, 2025

Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.

Original issue description:

This repository is a port of microsoft/TypeScript from TypeScript to Go. Since the port began, the following pull request was applied to microsoft/TypeScript. An equivalent change now needs to be applied here.

PR to port

Instructions

  1. Use playwright to view the PR listed above
  2. Apply the edits made in that PR to this codebase, translating them from TypeScript to Go.
    • The change may or may not be applicable. It may have already been ported. Do not make any significant changes outside the scope of the diff. If the change cannot be applied without significant out-of-scope changes, explain why and stop working.
    • Tip: search for functions and identifiers from the diff to find the right location to apply edits. Some files in microsoft/TypeScript have been split into multiple.
    • Tip: some changes have already been ported, like changes to diagnostic message text. Tests do not need to be ported as they are imported from the submodule.
  3. Check that the code builds by running npx hereby build in the terminal.
  4. Run tests. It is expected that tests will fail due to baseline changes.
    • Run npx hereby test in a terminal. They should fail with messages about baseline changes.
      • Tip: to run a single baseline test from the submodule, run go test ./internal/testrunner -run '^TestSubmodule/NAME_OF_TEST_FILE'
    • Run npx hereby baseline-accept to adopt the baseline changes.
    • Run git diff 'testdata/**/*.diff'. If your change is correct, these diff files will be reduced or completely deleted.
  5. Iterate until you are satisfied with your change. Commit everything, including the baseline changes in testdata, and open a PR.

Fixes #1126.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port TypeScript PR #59675: fix(59397): JsDoc is missing/duplicated in declarations for overloads declared in classes declared in functions
2 participants