Add support for JSDoc @implements tag in reparser #1104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the JSDoc
@implements
tag by implementing the missing case in the reparser to create synthetic heritage clauses.Problem
The JSDoc
@implements
tag was already being parsed correctly injsdoc.go
, but the reparser inreparser.go
was missing the case to handleKindJSDocImplementsTag
. This meant that while the tag was recognized, it wasn't being converted into a synthetic heritage clause that TypeScript tooling could understand.Solution
Added a case for
ast.KindJSDocImplementsTag
in thereparseTags
function that:KindImplementsKeyword
tokenExamples
Before this change, JSDoc
@implements
tags were parsed but ignored:After this change, the reparser creates proper heritage clauses:
Testing
@implements {Foo}
creates heritage clause with implements keyword@implements
tags create multiple heritage clauses@implements {Bar<T>}
handled correctlyextends
clausesFixes #1103.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.