Skip to content

feat: Add -A switch #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2023
Merged

feat: Add -A switch #361

merged 4 commits into from
May 27, 2023

Conversation

shueybubbles
Copy link
Collaborator

Dedicated admin connection. Fixes #200

@shueybubbles shueybubbles added this to the May 2023 Release milestone May 25, 2023
@@ -7,12 +7,12 @@ import (
)

func init() {
if len(msdsn.ProtocolParsers) == 3 {
// reorder the protocol parsers to lpc->tcp->np
if len(msdsn.ProtocolParsers) == 4 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment on to why this is scoped to just amd64 on windows (per filename)? Not ARM64?

Copy link
Collaborator

@stuartpa stuartpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shueybubbles shueybubbles merged commit a63d168 into main May 27, 2023
@shueybubbles shueybubbles deleted the shueybubbles/200 branch May 27, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DAC support (-A) for go-sqlcmd
2 participants