Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

chore(package): update enzyme #492

Merged
merged 2 commits into from
Nov 19, 2018
Merged

chore(package): update enzyme #492

merged 2 commits into from
Nov 19, 2018

Conversation

layershifter
Copy link
Member

This PR updates enzyme and enzyme-adapter-react-16, they have correct support of Fragment and forwardRef APIs.

@codecov
Copy link

codecov bot commented Nov 19, 2018

Codecov Report

Merging #492 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #492   +/-   ##
=======================================
  Coverage   88.41%   88.41%           
=======================================
  Files          42       42           
  Lines        1450     1450           
  Branches      211      211           
=======================================
  Hits         1282     1282           
  Misses        163      163           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc7fa74...df6a43c. Read the comment docs.

@@ -33,7 +33,7 @@ describe('Icon', () => {
const renderedComponent = mountWithProviderAndGetComponent(
Icon,
<Icon name="fontIcon" />,
null,
undefined,
Copy link
Member Author

@layershifter layershifter Nov 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This argument is options, null and undefined aren't equal for default args:

function getValue(value = { foo: 'bar' }) {
  return value
}

console.log(getValue(null)) // => null
console.log(getValue(undefined)) // {foo: "bar"}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

@layershifter layershifter merged commit 3df60db into master Nov 19, 2018
@layershifter layershifter deleted the chore/bump-enzyme branch November 19, 2018 16:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants