This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(useAccessibility): add support for FocusZone #2275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
commented
Jan 27, 2020
| @@ -38,9 +38,7 @@ export interface IFocusZone { | |||
| /** | |||
| * FocusZone component props. | |||
| */ | |||
| export interface FocusZoneProps | |||
| extends FocusZoneProperties, | |||
| React.HTMLAttributes<HTMLElement | FocusZone> { | |||
There was a problem hiding this comment.
React.HTMLAttributes<HTMLElement | FocusZone> is really strange and looks broken.
It also creates collisions with other typings as HTMLAttributes includes callbacks like onClick and if FocusZone is included it creates onClick: (e: FocusZone) 💣
layershifter
commented
Jan 27, 2020
| if (definition.focusZone) { | ||
| let element: React.ReactElement = children | ||
|
|
||
| if (process.env.NODE_ENV !== 'production') { |
There was a problem hiding this comment.
It's already restricted by typings, but it will be also good to have a runtime checks
Perf comparison
Generated by 🚫 dangerJS |
mnajdova
reviewed
Jan 27, 2020
| mergeProps(slotName, slotProps, definition) | ||
|
|
||
| // Provides an experimental handling for FocusZone definition in behaviors | ||
| getA11Props.unstable_withFocusZone = (children: React.ReactElement) => { |
There was a problem hiding this comment.
Would suggest renaming to unstable_wrapwithFocusZone
mnajdova
reviewed
Jan 27, 2020
| mergeProps(slotName, slotProps, definition) | ||
|
|
||
| // Provides an experimental handling for FocusZone definition in behaviors | ||
| getA11Props.unstable_withFocusZone = (children: React.ReactElement) => { |
There was a problem hiding this comment.
It's a bit confusing in this context, what is children and what is element... Let's simplify it a bit.
mnajdova
approved these changes
Jan 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an experimental support for
FocusZoneto theuseAccessibilityhook as FocusZone behavior can be described in accessibility behaviors.No changelog entries as this feature is an experimental. To be sure that this API is good we need to do more components, however there should be a way to use
FocusZoneright now and it allows to avoid breaking changes until we will be sure.