This repository was archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
commented
Dec 11, 2019
exampleName, | ||
...fieldValues[exampleName], | ||
]), | ||
row => -row[fields.indexOf('median')], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've sorted the yarn perf
results by their median values with the slowest components up top.
Generated by 🚫 dangerJS |
miroslavstastny
approved these changes
Dec 11, 2019
Some of these are adding a considerable amount of time (many minutes just for |
This was referenced Dec 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the perf test plan here #773. This PR adds more perf examples/tests. The minimal scenario tests (no props) were added for every component.
Component Story Format (CSF)
Perf examples follow the Component Story Format. Any doc example can now be written in Storybook's Component Story Format.CSF breaks everything :/
SourceRender
package used for live code editing also expects the renderable component to be the default exportyarn perf
does not run on CSF examplesUntil CSF takes off more in the community and there is more support, we will stick with what works everywhere.
Perf Example Naming
Perf example naming follows this pattern,
$Component$ExampleName.perf.tsx
:yarn perf
Running yarn perf works for all new perf examples. It also now has a sorted table of results.