This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Tree): left and right arrow keyboard navigation #1451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviuaavram
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
silviuaavram
added
accessibility
Codecov Report
@@ Coverage Diff @@
## master #1451 +/- ##
==========================================
+ Coverage 73.45% 73.59% +0.14%
==========================================
Files 806 807 +1
Lines 6088 6117 +29
Branches 1779 1785 +6
==========================================
+ Hits 4472 4502 +30
+ Misses 1610 1609 -1
Partials 6 6
Continue to review full report at Codecov.
|
sophieH29
reviewed
Jun 6, 2019
sophieH29
reviewed
Jun 6, 2019
packages/react/src/lib/accessibility/Behaviors/Tree/treeBehavior.ts
Outdated
Show resolved
Hide resolved
sophieH29
reviewed
Jun 6, 2019
packages/react/src/lib/accessibility/Behaviors/Tree/treeTitleBehavior.ts
Show resolved
Hide resolved
bmdalex
reviewed
Jun 7, 2019
…stardust-ui/react into feat-tree-navigation-left-right
sophieH29
reviewed
Jun 7, 2019
sophieH29
reviewed
Jun 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the ARIA design pattern https://www.w3.org/TR/wai-aria-practices-1.1/examples/treeview/treeview-1/treeview-1a.html
On Left Arrow, it should collapse tree if it is open. If it is closed, it should move focus to parent.
On Right Arrow, it should expand tree if it is closed and has subtree. If it is open, it should move focus to first child in subtree.
Also removed circular navigation provided by the FocusZone.
WIP: Unit Tests.