Union type fixes and optimizations #942
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues relating to apparent types and union types and optimizes materialization of properties in union types. It also makes union types a separate kind of type, distinct from object types.
The following functions have changed:
The functions in bold are the ones that code would typically use. They now automatically create synthetic results for union types and convert primitives and type parameters to their apparent types before performing the operation.
The ResolvedObjectType type has been renamed to ResolvedType because it now covers both object and union types. The ApparentType type is no longer needed and has been removed.
Materialization of union type properties previously happened in resolveObjectTypeMembers but is now done on demand per property through the getPropertyOfType function.