Skip to content

Fix completion entry conversion to protocol format #59410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2024
Merged

Fix completion entry conversion to protocol format #59410

merged 2 commits into from
Jul 24, 2024

Conversation

gabritto
Copy link
Member

Fixes an oversight in #59339.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 24, 2024
@gabritto gabritto requested a review from andrewbranch July 24, 2024 19:43
andrewbranch
andrewbranch approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just use object rest/spread to prevent us from needing future updates here?

@gabritto gabritto merged commit 0c33c13 into main Jul 24, 2024
32 checks passed
@gabritto gabritto deleted the gabritto/fixcc branch July 24, 2024 19:59
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Jul 24, 2024 •
edited
Loading

Should we just use object rest/spread to prevent us from needing future updates here?

I think the usual issue is excess stuff getting through unnecessarily, plus incorrectly spreading at the end vs. at the beginning.

@gabritto gabritto mentioned this pull request Jul 24, 2024
Merged
@sandersn sandersn removed this from PR Backlog Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

Assignees

@gabritto gabritto

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabritto @DanielRosenwasser @andrewbranch @typescript-bot