Handles time on vfs and write non empty shadowed files in baseline even if they were not read #48703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
sheetalkamat
force-pushed
the
moreBaselines
branch
from
cb3ebad to
be9ad59
Compare
rbuckton
previously requested changes
Apr 15, 2022
|
Ping @rbuckton |
Merged
|
@sandersn Does this affect your VFS work? |
|
The baselines certainly look better. If Ron and Nathan are happy, then I'm happy. |
|
It’s unrelated to @sandersn ’s vfs work since that uses virtual file system with watch (which is what we use to test for watch related or server related things ) |
sheetalkamat
dismissed
rbuckton’s stale review
Keeping things simple.. #48703 (comment)
amcasey
approved these changes
Apr 21, 2022
Jack-Works
pushed a commit
to Jack-Works/TypeScript
that referenced
this pull request
Apr 22, 2022
…en if they were not read (microsoft#48703) * Use fixed time for vfs so baselining is consistent * Baseline buildinfos * Write new file text in baseline even if the file wasnt read on the shadow * Remove unnecessary debugger statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change includes
Note this is in preparation for storing some of the timestamps in buildinfo